Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor golangci-lint for gosec 2.21.4 Overflow Checks (G115) Update #73

Open
fabiovincenzi opened this issue Oct 25, 2024 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@fabiovincenzi
Copy link
Collaborator

fabiovincenzi commented Oct 25, 2024

We relies on golangci-lint version 1.61.0 since #72, which currently includes gosec version 2.21.2. In gosec version 2.21.4, a significant improvement was introduced for detecting integer overflows in rule G115 through bound checks. This enhancement, documented in gosec Issue #1187, would help us catch potential overflow vulnerabilities more effectively once available in golangci-lint.

References:
gosec Issue #1187 - Details the addition of bound checks for G115.
gosec Release Notes - Overview of recent gosec updates.

@nojaf
Copy link
Collaborator

nojaf commented Oct 25, 2024

For those reading this, the todo item is to remove //nolint:gosec // disable G115 and update the code accordingly.

@nojaf nojaf added the help wanted Extra attention is needed label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: Backlog
Development

No branches or pull requests

2 participants