-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go version from 1.22 to 1.23 #72
Conversation
Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
Please also update golangci-lint: https://github.com/golangci/golangci-lint/releases/tag/v1.61.0 |
Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
@fabiovincenzi there were a couple of //nolint:ireturn comments that were removed. |
Signed-off-by: Fabio Vincenzi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, would like @dsuhinin to skim through this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Florian Verdonck <[email protected]>
Fixes #65
go mod tidy
golangci-lint
,mockery
andproton-gen-go