Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version from 1.22 to 1.23 #72

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Conversation

fabiovincenzi
Copy link
Collaborator

@fabiovincenzi fabiovincenzi commented Oct 24, 2024

Fixes #65

  • Upgrade go version from 1.22 to 1.23
  • Run go mod tidy
  • Upgrade golangci-lint, mockery and proton-gen-go
  • regenerate mocks and protos

Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
@nojaf
Copy link
Collaborator

nojaf commented Oct 24, 2024

Please also update golangci-lint: https://github.com/golangci/golangci-lint/releases/tag/v1.61.0
and mockery: https://github.com/vektra/mockery/releases/tag/v2.46.3
Perhaps (https://pkg.go.dev/google.golang.org/protobuf/cmd/protoc-gen-go, do in separate commit, see what CI says, if negative don't go for it)

Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
Signed-off-by: Fabio Vincenzi <[email protected]>
@nojaf
Copy link
Collaborator

nojaf commented Oct 24, 2024

@fabiovincenzi there were a couple of //nolint:ireturn comments that were removed.
You need to restore these. The clue is that the linter should now not mark these as false positives anymore.

Signed-off-by: Fabio Vincenzi <[email protected]>
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, would like @dsuhinin to skim through this as well.

Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf nojaf merged commit c1b15d9 into mlflow:main Oct 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Go to 1.23
3 participants