[WIP] Build open_clip as container and publish on push to main #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeadie
changed the title
Jeadie
force-pushed
the
jeadie/containers
branch
from
ff54066
to
6fb1d39
Compare
Jeadie
force-pushed
the
jeadie/containers
branch
from
6fb1d39
to
3e2c075
Compare
|
@Jeadie re the 403 forbidden in the PR run, I assume that will succeed once merged, or is there any token/secret that needs to be added |
|
Yeah, the GH action run looks to have successfully built the image, just unable to push. Also the above |
Jeadie
force-pushed
the
jeadie/containers
branch
from
6ecb77c
to
3e2c075
Compare
|
Incidental merge of |
|
@rwightman, can i please get a second look at this PR? Only failing GH action/check is a 403. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (at @marqo-ai) use
open_clipin a containerised environment. We currently run/use this repository as a container (see @Jeadie's packages).I think it'd be good to contribute these back to open_clip and have the image's hosted centrally.
Let me know if you have any questions, or what changes you'd like to see.