improve result by use the noise level after first iteration #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controlPoints is a 0|1 array instead of x values
lpatiny
reviewed
Apr 26, 2024
src/index.js
Outdated
|
|
||
| let baseline, iteration; | ||
| let nbPoints = y.length; | ||
| let l = nbPoints - 1; | ||
| let sumNegDifferences = Number.MAX_SAFE_INTEGER; | ||
| let stopCriterion = tolerance * y.reduce((sum, e) => Math.abs(e) + sum, 0); |
There was a problem hiding this comment.
This is super slow code. How big is y ?
There was a problem hiding this comment.
what do you mean with slow?, the size of y depends, usually 128K or more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting baseline zones correctly
The result after only one iteration is:
Without baseline detection, after seven iterations:
The baseline is now in the middle of the noise