feat: add xyEnsureFloat64 function #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Mar 6, 2024
Comment on lines
+5
to
+8
| interface DataXYNumberArray { | ||
| x: NumberArray; | ||
| y: NumberArray; | ||
| } |
There was a problem hiding this comment.
How is that different from DataXY<NumberArray> ?
There was a problem hiding this comment.
I created cheminfo/cheminfo-types#99 to allow NumberArray in the DataXY type
targos
added a commit
to cheminfo/cheminfo-types
that referenced
this pull request
Mar 7, 2024
It's a generic enough type that we shouldn't restrict it too much. Refs: mljs/spectra-processing#224
targos
added a commit
to cheminfo/cheminfo-types
that referenced
this pull request
Mar 12, 2024
It's a generic enough type that we shouldn't restrict it too much. Refs: mljs/spectra-processing#224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.