-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate interior state and boundary forcing to only predict state #84
base: main
Are you sure you want to change the base?
Conversation
This is now ready for a first review. As mentioned in the description this is only changes to the modeling side of things, and I have tweaked the existing MEPS dataloading to be able to test these changes. We will have to see if the changes to dataloading (building on top of #66) should be in a separate PR or just added to this one. I could see both as good solutions. There are two things preventing tests to pass for this:
My idea is that this could get a quick review right now, just considering the current changes, and then we can make up a plan w.r.t. the merging or continued work on this. Don't spend time on the changes to the MEPS dataloading made here, as that will anyhow be replaced with #66. |
b89a4e6
to
24bb665
Compare
Describe your changes
The goal of this PR is to establish a clear separation of the (predicted) state in the interior region and the boundary forcing coming from outside (and potentially overlapping with) the limited area. This PR performs these changes on the modeling side. That is from each batch is fetched from the dataset class and onward. Including how the tensors are propagated through the model, loss calculation, evaluation and plotting. This should be complemented with a separate PR for handling the data-loading side of things, where the boundary forcing could come from a separate dataset. That change should then build upon #66, once merged.
Note: In order to allow for working on this before the change has been done on the data loading side this currently includes changes in the MEPS npy dataset class that separates state and boundary already in there. This defines the interface between the dataset and model (currently missing #64 from #66, but that can easily be added later) and allows for working on these separately.
After this change:
Dependencies:
This introduces a dependency to https://github.com/mllam/weather-model-graphs. In particular, this dependency should be adjusted before merging to require a version after mllam/weather-model-graphs#34 has been merged.
Issue Link
No issue specific to the separation of interior state. This relates to the overall rework of Reading Training Data, but would be good to put as separate point on roadmap.
This includes graph-creation with wmg (#83).
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee