Use environment variable to specify protractor location #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
gulp-protractor doesn't work with --no-bin-links as .bin doesn't exist. This could be a good work around for this. Can this be merged? |
Conflicts: index.js
|
@jfstephe done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In some situations, it's useful to be able to specify one protractor install location to use.
For instance, one of my clients prevents any .cmd or .bat file to be executed outside of a specific directory (where global npm packages are installed). Thus, I needed to tell gulp-protractor to use the globally installed protractor.
This PR introduces the PROTRACTOR_DIR environment variable to specify the directory where the protractor and webdriver-manager binaries / wrappers are located.