Try to fix OS X build #3837
Try to fix OS X build #3837
Conversation
|
@mlpack-jenkins test this please |
|
The R build is still failing due to the deprecation issues, but the PR itself does its job (fix the regular OS X build) so it's ready for review. |
|
Did you see the similar hotfix in the r-actions thread I mentioned on Matrix? In this comment Kirill suggests to uninstall as you do but then (as I read it) let the R install take care of the remainder. Anyway, it seems as if the runner image will come back repaired in due course too. |
|
Yeah, I saw that, but for the jobs I fixed here, they are the general mlpack OS X jobs, so it is not guaranteed that R will even be used. So in that case it makes sense just to reinstall pkg-config on the spot. |
|
Do you want me to approve this? So that the bot will give a 2nd vote in 24 hours unless someone else preempts? |
|
If you're comfortable with the change, then yes please :) |
| @@ -13,6 +13,8 @@ steps: | |||
| - script: | | |||
| set -e | |||
| sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer | |||
| brew uninstall [email protected] | |||
| brew install pkg-config | |||
There was a problem hiding this comment.
As this is a hot-fix for a temporary issue, shall we place a 'reminder' somewhere to see about reverting to normal "in due course" ?
There was a problem hiding this comment.
Good idea, done in aeac96e. 👍
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Well, I looked on another PR and everything is working there. So apparently this was a transient problem that doesn't even need a workaround anymore. |
Another day, another strange issue that has nothing to do with mlpack. Sigh.
(Let's see how many iterations it takes to fix.)