feat: add callbacks for resample and benchmark #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sebastian Fischer <[email protected]>
be-marc
commented
Feb 6, 2025
| #' | ||
| #' @description | ||
| #' Specialized [mlr3misc::Callback] to customize the behavior of [resample()] and [benchmark()] in mlr3. | ||
| #' The [callback_resample()] function is used to create instances of this class. |
There was a problem hiding this comment.
What can you do with callbacks?
There was a problem hiding this comment.
For example save file to disk or extract information from models
mb706
reviewed
Feb 6, 2025
| #' @param null_ok (`logical(1)`)\cr | ||
| #' If `TRUE`, `NULL` is allowed. | ||
| #' | ||
| #' @return [CallbackResample | List of [CallbackResample]s. |
mb706
reviewed
Feb 6, 2025
Comment on lines
+555
to
+556
| cns = c("uhash", "task", "learner", "resampling", "iteration", "prediction") | ||
| if ("data_extra" %in% names(tab)) cns = c(cns, "data_extra") |
There was a problem hiding this comment.
Maybe instead something like
Suggested change
| cns = c("uhash", "task", "learner", "resampling", "iteration", "prediction") | |
| if ("data_extra" %in% names(tab)) cns = c(cns, "data_extra") | |
| cns = c("uhash", "task", "learner", "resampling", "iteration", "prediction", | |
| if ("data_extra" %in% names(tab)) "data_extra") |
(same story further down)
mb706
reviewed
Feb 6, 2025
| @@ -373,7 +380,9 @@ ResampleResult = R6Class("ResampleResult", | |||
| as.data.table.ResampleResult = function(x, ..., predict_sets = "test") { # nolint | |||
| private = get_private(x) | |||
| tab = private$.data$as_data_table(view = private$.view, predict_sets = predict_sets) | |||
| tab[, c("task", "learner", "resampling", "iteration", "prediction"), with = FALSE] | |||
| cns = c("task", "learner", "resampling", "iteration", "prediction") | |||
| if ("data_extra" %in% names(tab)) cns = c(cns, "data_extra") | |||
be-marc
commented
Feb 6, 2025
| #' | ||
| #' @export | ||
| #' @examples | ||
| #' task = tsk("pima") |
There was a problem hiding this comment.
Add more examples also with data_extra
be-marc
commented
Feb 6, 2025
| #' ``` | ||
| #' Start Resampling Iteration on Worker | ||
| #' - on_resample_begin | ||
| #' (Split `ctx$task` into training and test set with `ctx$resampling` and `ctx$iteration`) |
There was a problem hiding this comment.
Clarify that this happens in workhorse() and not in the callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.