Merge pull request #119 from mlr-org/catboost_param

Update learner_catboost_classif_catboost.R
mlr-org · Oct 12, 2021 · acb2fc7 · acb2fc7
2 parents fb4976d + ca179ba
commit acb2fc7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: mlr3extralearners
 Title: Extra Learners For mlr3
-Version: 0.5.9
+Version: 0.5.10
 Authors@R:
     c(person(given = "Raphael",
              family = "Sonabend",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# mlr3extralearners 0.5.10
+
+* Added params `ignored_features` and `one_hot_max_size` to `classif.catboost`
+
 # mlr3extralearners 0.5.9
 
 * Fixed bug that didn't allow C parameter to be set for nu-regression

diff --git a/R/learner_catboost_classif_catboost.R b/R/learner_catboost_classif_catboost.R
@@ -73,8 +73,8 @@ LearnerClassifCatboost = R6Class("LearnerClassifCatboost",
         grow_policy = p_fct(levels = c("SymmetricTree", "Depthwise", "Lossguide"), default = "SymmetricTree", tags = "train"),
         min_data_in_leaf = p_int(lower = 1L, upper = Inf, default = 1L, tags = "train"),
         max_leaves = p_int(lower = 1L, upper = Inf, default = 31L, tags = "train"),
-        # ignored_features missing
-        # one_hot_max_size missing
+        ignored_features = p_uty(default = NULL, tags = "train"),
+        one_hot_max_size = p_uty(default = FALSE, tags = "train"),
         has_time = p_lgl(default = FALSE, tags = "train"),
         rsm = p_dbl(lower = 0.001, upper = 1, default = 1, tags = "train"),
         nan_mode = p_fct(levels = c("Min", "Max"), default = "Min", tags = "train"), # do not allow "Forbidden"