feat: marshall rweka models

mlr-org · Nov 14, 2024 · dfe3b59 · dfe3b59
1 parent 6ccad99
commit dfe3b59
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 7 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -1,7 +1,7 @@
 # Generated by roxygen2: do not edit by hand
 
 S3method(marshal_model,Weka_classifier)
-S3method(unmarshal_model,Weka_classifier)
+S3method(unmarshal_model,Weka_classifier_marshaled)
 export(LearnerClassifAbess)
 export(LearnerClassifAdaBoostM1)
 export(LearnerClassifBart)

diff --git a/R/helpers_rweka.R b/R/helpers_rweka.R
@@ -59,17 +59,16 @@ rweka_predict = function(newdata, pars, predict_type, model) {
 
 #' @export
 #' @method marshal_model.Weka_classifier
-marshal_model.Weka_classifier= function(model, inplace = FALSE, ...) {
+marshal_model.Weka_classifier = function(model, inplace = FALSE, ...) {
   rJava::.jcache(model$classifier)
-
   structure(list(
-    marshaled = model, packages = "mlr3extralearners"),
-    class = c("classif.Weka_classifier_marshaled", "marshaled")
+    marshaled = model, packages = c("mlr3", "mlr3extralearners")),
+    class = c("Weka_classifier_marshaled", "marshaled")
   )
 }
 
 #' @export
-#' @method unmarshal_model.Weka_classifier
-unmarshal_model.Weka_classifier = function(model, inplace = FALSE, ...) {
+#' @method unmarshal_model.Weka_classifier_marshaled
+unmarshal_model.Weka_classifier_marshaled = function(model, inplace = FALSE, ...) {
   model$marshaled
 }
diff --git a/man/mlr_learners_classif.AdaBoostM1.Rd b/man/mlr_learners_classif.AdaBoostM1.Rd