Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable test set usage in graph #750

Closed
wants to merge 5 commits into from
Closed

Conversation

sebffischer
Copy link
Member

not quite done

@sebffischer
Copy link
Member Author

sebffischer commented Jan 23, 2024

How do we deal with the problems where the same rows are used for training and predicting, but they are preprocessed differently? In this scenario, we cannot simply pass ONE task to the learner.

We can deal with this problem in different ways:

  1. We can simply ensure that the test rows are disjunct from the predict rows (seems simple enough).
  2. We can make the private $.train method of the learner accept an additional argument task_predict.

I guess 1) Would probably be easier and good enough.

Also: task's rbind does not allow overwriting already existing rows it seems like

@sebffischer
Copy link
Member Author

Also: task's rbind does not allow overwriting already existing rows it seems like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant