Skip to content

[Minio] change Minio parameters to secret in workflows. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: development
Choose a base branch
from
Draft

[Minio] change Minio parameters to secret in workflows. #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
df0eb0b
rename
tomerm-iguazio Mar 5, 2024
c668cd0
change to minio parameters
tomerm-iguazio Mar 5, 2024
d69ea1f
change to minio parameters
tomerm-iguazio Mar 5, 2024
ba6e8d2
addd enabled for minio
tomerm-iguazio Mar 5, 2024
8e4f79a
consider minio parameters as secret
tomerm-iguazio Mar 5, 2024
7f21593
format to b64enc
tomerm-iguazio Mar 5, 2024
0055929
Update charts/mlrun-ce/values.yaml
tomerm-iguazio Mar 5, 2024
6d3c926
Update charts/mlrun-ce/templates/config/minio-env-secret.yaml
tomerm-iguazio Mar 5, 2024
713e004
a bump to rc11
tomerm-iguazio Mar 5, 2024
413f160
Merge remote-tracking branch 'origin/minio_parameters' into minio_par…
tomerm-iguazio Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/mlrun-ce/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
version: 0.6.3-rc10
version: 0.6.3-rc11
name: mlrun-ce
description: MLRUn Open Source Stack
home: https://iguazio.com
Expand Down
10 changes: 0 additions & 10 deletions charts/mlrun-ce/templates/config/jupyter-env-configmap.yaml
View file
Open in desktop

This file was deleted.

10 changes: 10 additions & 0 deletions charts/mlrun-ce/templates/config/minio-env-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{{ if .Values.minio.enabled}}
apiVersion: v1
kind: Secret
metadata:
name: minio-env-secret
data:
S3_ENDPOINT_URL: {{ include "mlrun-ce.minio.service.url" . | b64enc | quote }}
AWS_SECRET_ACCESS_KEY: {{ .Values.minio.rootPassword | b64enc | quote }}
AWS_ACCESS_KEY_ID: {{ .Values.minio.rootUser | b64enc | quote }}
{{- end}}
3 changes: 0 additions & 3 deletions charts/mlrun-ce/templates/config/mlrun-env-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ data:
MLRUN_STORAGE__AUTO_MOUNT_TYPE: s3
MLRUN_STORAGE__AUTO_MOUNT_PARAMS: "aws_access_key=minio,aws_secret_key=minio123,endpoint_url={{ include "mlrun-ce.minio.service.url" . }}"
MLRUN_HTTPDB__PROJECTS__FOLLOWERS: nuclio
S3_ENDPOINT_URL: {{ include "mlrun-ce.minio.service.url" . }}
AWS_SECRET_ACCESS_KEY: {{ .Values.minio.rootPassword }}
AWS_ACCESS_KEY_ID: {{ .Values.minio.rootUser }}
MLRUN_HTTPDB__REAL_PATH: s3://
MLRUN_ARTIFACT_PATH: s3://mlrun/projects/{{ `{{run.project}}` }}/artifacts
MLRUN_FEATURE_STORE__DATA_PREFIXES__DEFAULT: s3://mlrun/projects/{project}/FeatureStore/{name}/{kind}
Expand Down
9 changes: 6 additions & 3 deletions charts/mlrun-ce/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ mlrun:
- configMapRef:
name: mlrun-override-env
optional: true
- secretRef:
name: minio-env-secret
optional : true
extraPersistentVolumeMounts: ~
ui:
fullnameOverride: mlrun-ui
Expand Down Expand Up @@ -192,9 +195,9 @@ jupyterNotebook:

extraEnvKeyValue: {}
envFrom:
- configMapRef:
name: jupyter-common-env
optional: true
- secretRef:
name: minio-env-secret
optional: true
persistence:
enabled: true
existingClaim:
Expand Down