Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification in images #208

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Modification in images #208

merged 3 commits into from
Oct 16, 2023

Conversation

anushka9555
Copy link

Modified the images to the required aspect ratio.

@anushka9555
Copy link
Author

Hi @Sammybams I tried changing the aspect ratio and created a new PR. Please check if it is fine. Since I am new to open source I don't have much idea about the things now. Sorry for any inconvenience.

Copy link
Collaborator

@Sammybams Sammybams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @an for your contribution.
It also seems you have not correctly categorized the buildings.

Project_1/Data/Bungalow/Zanu_Bunglow.jpeg should be a storey building.
Project_1/Data/Bungalow/Zanu_bunglow_1.jpeg should be a storey building.
Project_1/Data/Bungalow/Zanu_bunglow_3.jpegshoud be a storey building.

Project_1/Data/High-rise/Zanu_high_rise.jpeg isn't a high-rise building and is more like a storey building.
Project_1/Data/High-rise/Zanu_high_rise_1.jpg is a storey building.

Please effect this changes and then we would be happy to merge your pull request. Thank you very much.

@anushka9555
Copy link
Author

Hi @Sammybams. Done the changes

Copy link
Collaborator

@Sammybams Sammybams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @anushka9555.

@Sammybams Sammybams merged commit 716b950 into mlsanigeria:main Oct 16, 2023
@anushka9555
Copy link
Author

Hi @Sammybams. Just a small request. Can you please add hacktoberfest 2023 and hacktoberfest accepted labels to this PR? Thank you so much.

@Sammybams
Copy link
Collaborator

Alright @anushka9555.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants