fix: handle arbitrary newline terminators #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I'm not happy with the way the code looks, but I feel we need a fix for such cases since pickle loads it anyway |
mmaitre314
requested changes
Mar 26, 2024
McPatate
force-pushed
the
fix/handle_aribtrary_newlines_terminators
branch
from
133bac0 to
f5edabf
Compare
|
Refactored, this is much better imo. Lmk what you think, the difference here is that if there is an error, at least return the already extracted globals. |
McPatate
force-pushed
the
fix/handle_aribtrary_newlines_terminators
branch
from
2f75026 to
e10a0f5
Compare
mmaitre314
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picklescan (well technically pickletools) fails to parse https://huggingface.co/Narsil/totallysafe/blob/main/pytorch_model.bin as it is newline terminated given it was handcrafted in an editor.
The following PR should address that.