lib: Kconfig.debug: Fix the recursive dependency

An earlier commit 52a3101 added a recursive dependency as part of CONFIG_DEBUG_SPINLOCK lib/Kconfig.debug:585:error: recursive dependency detected! lib/Kconfig.debug:585:symbol DEBUG_SPINLOCK_BITE_ON_BUG depends on DEBUG_SPINLOCK_PANIC_ON_BUG lib/Kconfig.debug:593:symbol DEBUG_SPINLOCK_PANIC_ON_BUG depends on DEBUG_SPINLOCK_BITE_ON_BUG Fix this by adding a choice menu. Change-Id: I0e50103397bb71dec7056db5148cba988550b860 Signed-off-by: Rohit Vaswani <[email protected]>
mmaret-geny · Nov 13, 2014 · caebe7c · caebe7c
1 parent 3e284bf
commit caebe7c
Showing 1 changed file with 21 additions and 15 deletions.
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
@@ -582,21 +582,27 @@ config DEBUG_SPINLOCK
 	  best used in conjunction with the NMI watchdog so that spinlock
 	  deadlocks are also debuggable.
 
-config DEBUG_SPINLOCK_BITE_ON_BUG
-	bool "Cause a Watchdog Bite on Spinlock bug"
-	depends on DEBUG_SPINLOCK && !DEBUG_SPINLOCK_PANIC_ON_BUG && MSM_WATCHDOG_V2
-	help
-	  On a spinlock bug, cause a watchdog bite so that we can get the precise
-	  state of the system captured at the time of spin dump. This is mutually
-	  exclusive with the below DEBUG_SPINLOCK_PANIC_ON_BUG config.
-
-config DEBUG_SPINLOCK_PANIC_ON_BUG
-	bool "Cause a Kernel Panic on Spinlock bug"
-	depends on DEBUG_SPINLOCK && !DEBUG_SPINLOCK_BITE_ON_BUG
-	help
-	  On a spinlock bug, cause a kernel panic so that we can get the complete
-	  information about the system at the time of spin dump in the dmesg.
-	  This is mutually exclusive with the above DEBUG_SPINLOCK_BITE_ON_BUG.
+choice
+	prompt "Perform Action on spinlock bug"
+	depends on DEBUG_SPINLOCK
+
+	default DEBUG_SPINLOCK_BITE_ON_BUG
+
+	config DEBUG_SPINLOCK_BITE_ON_BUG
+		bool "Cause a Watchdog Bite on Spinlock bug"
+		depends on MSM_WATCHDOG_V2
+		help
+		  On a spinlock bug, cause a watchdog bite so that we can get the precise
+		  state of the system captured at the time of spin dump. This is mutually
+		  exclusive with the below DEBUG_SPINLOCK_PANIC_ON_BUG config.
+
+	config DEBUG_SPINLOCK_PANIC_ON_BUG
+		bool "Cause a Kernel Panic on Spinlock bug"
+		help
+		  On a spinlock bug, cause a kernel panic so that we can get the complete
+		  information about the system at the time of spin dump in the dmesg.
+		  This is mutually exclusive with the above DEBUG_SPINLOCK_BITE_ON_BUG.
+endchoice
 
 config DEBUG_MUTEXES
 	bool "Mutex debugging: basic checks"