Keep Scrutinizr happy-ish

mmikkel · Mar 28, 2024 · 2503102 · 2503102
1 parent ba7e754
commit 2503102
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/CacheFlag.php b/src/CacheFlag.php
@@ -198,7 +198,7 @@ private function _maybeInvalidateFlaggedCachesByElement(?ElementInterface $eleme
         } catch (\Throwable) {
             // We don't care about handling this exception
         }
-        CacheFlag::getInstance()->cacheFlag->invalidateFlaggedCachesByElement($element);
+        $this->cacheFlag->invalidateFlaggedCachesByElement($element);
     }
 
 }
diff --git a/src/services/CacheFlagService.php b/src/services/CacheFlagService.php
@@ -51,21 +51,21 @@ public function getAllFlags(): array
     }
 
     /**
-     * @param string|string[] $flags
+     * @param string|string[]|null $flags
      * @param string $sourceColumn
      * @param string $sourceValue
      * @throws \Throwable
      * @throws \yii\db\Exception
      */
-    public function saveFlags($flags, string $sourceColumn, string $sourceValue)
+    public function saveFlags(string|array|null $flags, string $sourceColumn, string $sourceValue): void
     {
 
-        if (!$flags) {
+        if (empty($flags)) {
             return;
         }
 
-        if (\is_array($flags)) {
-            $flags = \implode(',', $flags);
+        if (is_array($flags)) {
+            $flags = implode(',', $flags);
         }
 
         $uid = (new Query())