This repository has been archived by the owner on Aug 28, 2019. It is now read-only.
Running into a Docker container #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpou
changed the title
| # Install bundle of gems | ||
| WORKDIR /tmp | ||
| COPY Gemfile /tmp/ | ||
| RUN bundle install |
There was a problem hiding this comment.
In a container, I don't believe that /tmp will get wiped since the container never technically shuts down. You should clean up /tmp explicitly once you are done running a bundle install.
|
|
||
| MAINTAINER Maxence POUTORD <[email protected]> | ||
|
|
||
| RUN apt-get update |
There was a problem hiding this comment.
doing a dist-upgrade is also recommended
| RUN bundle install | ||
|
|
||
| # Copy site into | ||
| VOLUME /site |
There was a problem hiding this comment.
using a volume is unnecessary if you are copying files in. The volume is nice from a live reload perspective, but the copy is nicer for hosting options if someone wants to throw the container up on an Azure App Service or something. I'm not against setting up a volume AND copying, but I think this could be handled more gracefully (perhaps 2 dockerfiles?).
misterwell
pushed a commit
to misterwell/misterwell.github.io
that referenced
this pull request
Jan 17, 2019
facebook sharing image meta tag added related mmistakes#149 issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.