visibility=hidden to not pollute the global symbol space

mmomtchev · Oct 29, 2023 · 217393e · 217393e
1 parent 860acc2
commit 217393e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -99,6 +99,7 @@
             'MACOSX_DEPLOYMENT_TARGET': '10.7',
             'OTHER_CPLUSPLUSFLAGS': [ '-std=c++14' ]
           },
+          'cflags': [ '-fvisibility=hidden '],
           'cflags_cc': [ '-std=c++14' ],
           'cflags!': [ '-fno-exceptions' ],
           'cflags_cc!': [ '-fno-exceptions' ],

diff --git a/src/main.cc b/src/main.cc
@@ -110,7 +110,7 @@ static void InitDebug() {
 }
 #endif
 
-Napi::Object Pymp_Init(Env env, Object exports) {
+static Napi::Object PympInit(Env env, Object exports) {
 #ifdef DEBUG
   InitDebug();
 #endif
@@ -223,4 +223,4 @@ Napi::Object Pymp_Init(Env env, Object exports) {
   return exports;
 }
 
-NODE_API_MODULE(pymport, Pymp_Init)
+NODE_API_MODULE(pymport, PympInit)