Skip to content

Commit

Permalink
drop Node.js 14
Browse files Browse the repository at this point in the history
  • Loading branch information
mmomtchev committed Feb 7, 2024
1 parent a06c1ef commit 2ea426a
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 27 deletions.
16 changes: 2 additions & 14 deletions .github/workflows/test-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,8 @@ jobs:
- windows-2022
- macos-11
- macos-12
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
exclude:
- node-version: 14.x # node-gyp not compatible with Python 3.11
python-version: "3.11"
- node-version: 14.x # node-gyp not compatible with Python 3.12
python-version: "3.12"

steps:
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -70,15 +65,8 @@ jobs:
strategy:
matrix:
platform: [ubuntu-20.04, ubuntu-22.04, windows-2019, macos-11]
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x]
python-version: ["3.8", "3.9", "3.10", "3.11"]
exclude:
- node-version: 14.x # Node.js crypto not compatible with Ubuntu 22
platform: ubuntu-22.04
- node-version: 16.x # Node.js crypto not compatible with Ubuntu 22
platform: ubuntu-22.04
- node-version: 14.x # node-gyp not compatible with Python 3.11
python-version: "3.11"

steps:
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/test-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,8 @@ jobs:
- windows-2022
- macos-11
- macos-12
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
exclude:
- node-version: 14.x
python-version: "3.11"
- node-version: 14.x
python-version: "3.12"

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.5.0]
- Add Python 3.12 support and upgrade the built-in Python to 3.12.2
- Drop Node.js 14 support

### [1.4.3] 2023-10-29
- Fix [#104](https://github.com/mmomtchev/pymport/issues/104), do not mess up the loading of additional binary modules after `pymport`

Expand Down
10 changes: 4 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,12 @@ There is also a [medium stort](https://medium.com/@mmomtchev/using-numpy-and-pan
| Platforms | Versions |
| --------- | -------------------------------------------------------- |
| OS | Windows 2019 & 2022, Ubuntu 20.04 & 22.04, macOS 11 & 12 (x86 only) |
| Node.js | 14.x, 16.x and 18.x |
| Python | 3.8, 3.9, 3.10 and 3.11 |
| Node.js | 16.x, 18.x and 20.x |
| Python | 3.8, 3.9, 3.10, 3.11 and 3.12 |

except for the following combinations that are not supported:

* **Node.js 14.x with Python 3.11**: rebuilding from source is not possible due to `node-gyp` version being too old to support Python 3.11, upgrading `npm` or using the precompiled binaries solves this issue

* **Node.js 14.x/16.x on Ubuntu 22.04**: rebuilding from source against the system-installed Python is not possible due to Node.js containing a built-in OpenSSL 1.1 with exported symbols while the system-provided Python is built vs OpenSSL 3.0, upgrading Node.js or using the precompiled interpreter solves this issue
* **Node.js 16.x on Ubuntu 22.04**: rebuilding from source against the system-installed Python is not possible due to Node.js containing a built-in OpenSSL 1.1 with exported symbols while the system-provided Python is built vs OpenSSL 3.0, upgrading Node.js or using the precompiled interpreter solves this issue

* **Python 3.11.x on Windows**: An upstream bug requires a specific workaround in this case [#44](https://github.com/mmomtchev/pymport/issues/44)

Expand All @@ -78,7 +76,7 @@ The wiki has a list of some known and hard to fix issues:

# License

Copyright 2022-2023 Momtchil Momtchev <[email protected]> and contributors
Copyright 2022-2024 Momtchil Momtchev <[email protected]> and contributors

Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"typescript": "^4.9.5"
},
"engines": {
"node": ">= 14.0.0"
"node": ">= 16.0.0"
},
"dependencies": {
"@mapbox/node-pre-gyp": "^1.0.11",
Expand Down

0 comments on commit 2ea426a

Please sign in to comment.