Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump node-addon-api from 8.1.0 to 8.2.0" #281

Merged

Conversation

mmomtchev
Copy link
Owner

Reverts #280

Waiting on Node to get their hands out of their pockets and fix this, systematic memory leak when constructing an object...

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.70%. Comparing base (42334b9) to head (0c0c99b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/objstore.cc 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   94.84%   94.70%   -0.14%     
==========================================
  Files          14       14              
  Lines        1299     1304       +5     
==========================================
+ Hits         1232     1235       +3     
- Misses         67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmomtchev
Copy link
Owner Author

Who is calling napi_remove_wrap? When?

@mmomtchev mmomtchev merged commit 86ca17c into main Oct 3, 2024
131 checks passed
@mmomtchev mmomtchev deleted the revert-280-dependabot/npm_and_yarn/node-addon-api-8.2.0 branch October 3, 2024 09:45
@mmomtchev
Copy link
Owner Author

The ObjectWrap example leaks - both when using a factory method or when using the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant