Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added MqttQualityOfServiceLevel (optional) to connect Method #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mike7ang1rdz
Copy link

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a5bb24) 100.00% compared to head (7d155ef) 100.00%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #129   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          248       249    +1     
  Branches        37        37           
=========================================
+ Hits           248       249    +1     
Files Coverage Δ
....Extensions.External.RxMQTT.Client/RxMqttClient.cs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmuecke
Copy link
Owner

mmuecke commented Nov 21, 2023

Hi thanks for the contribution. I have checked the change and using the topic filter when creating the subscription may cause a problem. The subscription is only done once per topic. If this is done for the same topic with different topic filters, this can lead to subscriptions not being carried out correctly.

I would therefore filter the messages afterwards with the topic filter.

.FilterQoS(MqttQualityOfServiceLevel.ExactlyOnce)

@mike7ang1rdz
Copy link
Author

don't you think that is it too late to filter?

in scenarios when the client is offline or have network issues it is important to initialize the subscription with ExactlyOnce so mqtt server is aware of publish only once and confirm reception.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants