Allow inputs of class single to jsonencode (bug #64949)

* jsonencode.cc (encode_numeric): Change input validation test to isfloat() rather than is_double_type() to also accept single inputs. * jsonencode_BIST.tst: Add commented test for bug #64960.
mmuetzel · Dec 2, 2023 · 3ba8df6 · 3ba8df6
1 parent 625d115
commit 3ba8df6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/libinterp/corefcn/jsonencode.cc b/libinterp/corefcn/jsonencode.cc
@@ -75,7 +75,7 @@ encode_numeric (T& writer, const octave_value& obj,
   // Possibly write NULL for non-finite values (-Inf, Inf, NaN, NA)
   else if (ConvertInfAndNaN && ! octave::math::isfinite (value))
     writer.Null ();
-  else if (obj.is_double_type ())
+  else if (obj.isfloat ())
     writer.Double (value);
   else
     error ("jsonencode: unsupported type");

diff --git a/test/json/jsonencode_BIST.tst b/test/json/jsonencode_BIST.tst
@@ -15,6 +15,8 @@
 %! assert (isequal (jsonencode (logical (1)), 'true'));
 %! assert (isequal (jsonencode (logical (0)), 'false'));
 %! assert (isequal (jsonencode (50.025), '50.025'));
+%% FIXME: Uncomment when bug #64960 is fixed
+%!# assert (isequal (jsonencode (single (50.025)), '50.025'));
 %! assert (isequal (jsonencode (NaN), 'null'));
 %! assert (isequal (jsonencode (NA), 'null'));    % Octave-only test
 %! assert (isequal (jsonencode (Inf), 'null'));