[MRG] Fix copyfile_eeglab type conflicts

[laemtl]

PR Description

Fix #1122

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

• All comments are resolved
• This is not your own PR
• All CIs are happy
• PR title starts with [MRG]
• whats_new.rst is updated
• New contributors have been added to CITATION.cff
• PR description includes phrase "closes <#issue-number>"

[welcome]

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

[codecov]

Codecov Report

Merging #1126 (074ea18) into main (0b1a61d) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
- Coverage   95.29%   95.23%   -0.06%     
==========================================
  Files          40       40              
  Lines        8670     8671       +1     
==========================================
- Hits         8262     8258       -4     
- Misses        408      413       +5     

Impacted Files	Coverage Δ
mne_bids/copyfiles.py	97.72% <100.00%> (+0.01%)	⬆️
mne_bids/tests/conftest.py	93.75% <0.00%> (-6.25%)	⬇️
mne_bids/tests/test_write.py	90.17% <0.00%> (-0.15%)	⬇️
mne_bids/write.py	97.18% <0.00%> (-0.11%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sappelhoff]

circleci was a bit weird:

never saw that before ... anyone else? Manually restarting the workflow seems to have helped

[adam2392]

circleci was a bit weird:

never saw that before ... anyone else? Manually restarting the workflow seems to have helped

We saw it in mne-connectivity too: mne-tools/mne-connectivity#129 (comment)

[hoechenberger]

I would suggest to revert this change, as it makes the program flow less obvious

[laemtl]

In the current implementation, there is some potential cases where has_fdt_link will not be set and an error thrown. It happened to me during testing so that's how I tried to fix that. Would you prefer an else case instead?

    try:
        # If the data field is a string, it points to a .fdt file in src dir
        if isinstance(eeg['data'][0, 0][0], str):
            has_fdt_link = True
        else:
            has_fdt_link = False
    except IndexError:
        has_fdt_link = False

[sappelhoff]

For me both ways are fine. Thanks for figuring out that there is one potential flow that previously lead to an error!

[sappelhoff]

you need to add yourself here as well @laemtl

mne-bids/doc/authors.rst

Line 42 in 0b1a61d

.. _Moritz Gerster: http://moritz-gerster.com

[sappelhoff]

and here, just behind Moritz, please:

mne-bids/CITATION.cff

Line 154 in 0b1a61d

- given-names: Moritz

[welcome]

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

[sappelhoff]

Thanks @laemtl 🚀