optionally return event_id dict from read_raw_bids, and use value column from events file if present #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
==========================================
+ Coverage 97.42% 97.43% +0.01%
==========================================
Files 40 40
Lines 8883 8903 +20
==========================================
+ Hits 8654 8675 +21
+ Misses 229 228 -1 ☔ View full report in Codecov by Sentry. |
larsoner
reviewed
Dec 14, 2024
| # when making our `event_id` dict; `value = n/a` doesn't prevent annotation) | ||
| culled = _drop(events_dict, "n/a", "value") | ||
| event_id = dict( | ||
| zip(culled[trial_type_col_name], np.asarray(culled["value"], dtype=int)) |
There was a problem hiding this comment.
@drammock I think this is causing a failure in mne-bids-pipeline
Can you look? You should be able to do pytest mne_bids_pipeline/ -k matching --download to test
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
closes #223
I opted for @hoechenberger's suggestion in #223 (comment), namely, to allow
read_raw_bidsto optionally return anevent_iddict; when avaluescolumn is present inevents.tsvit will use those values for the integer IDs. That dict can then be passed tomne.events_from_annotationsto recover the original events array.Merge checklist
Maintainer, please confirm the following before merging.
If applicable: