Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Replace setup.py with pyproject.toml #160

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

adam2392
Copy link
Member

PR Description

First part of #159

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
@adam2392
Copy link
Member Author

adam2392 commented Dec 4, 2023

Is this along the lines of what you meant? @larsoner

I can make the CIs pass for #159, so then this is just an intermediary PR to get the files swapped out and then the next PR would run the formatters in #159, which would then make the CIs pass.

@larsoner
Copy link
Member

larsoner commented Dec 4, 2023

Yeah it would work to merge this with failing style CI then fix the style stuff in a separate PR which could then (later) be added to .git-blame-revs-ignore.

Also while you're at it we could enable pre-commit.ci and allow it to run your style checks if you want if you add a .pre-commit-config.yaml. But if that's too much for now you can do it later too

Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 requested a review from larsoner December 5, 2023 21:11
@adam2392
Copy link
Member Author

adam2392 commented Dec 5, 2023

Once this is good to go, I'll merge this and then proceed with the formatting in #159 and add to git-ignore.

I guess for the precommit stuff, I can just copy what MNE-Python has?

@larsoner
Copy link
Member

larsoner commented Dec 6, 2023

I guess for the precommit stuff, I can just copy what MNE-Python has?

Yes a subset of it at least. We just added some mypy stuff you don't need for example.

Feel free to merge and continue if you're ready @adam2392 !

@adam2392 adam2392 merged commit 52c3824 into mne-tools:main Dec 6, 2023
10 of 15 checks passed
@adam2392 adam2392 deleted the pkgv2 branch December 6, 2023 02:24
tsbinns pushed a commit to tsbinns/mne-connectivity that referenced this pull request Dec 15, 2023
* Add new toml files

---------

Signed-off-by: Adam Li <[email protected]>
larsoner added a commit to larsoner/mne-connectivity that referenced this pull request Jan 9, 2024
* upstream/main: (56 commits)
  [CI] Fix CIs (mne-tools#164)
  Fix azure
  Fix CIs
  New dev for v0.7
  [RELEASE] V0.6 (mne-tools#162)
  Try azure again
  [CI] Fix azure (mne-tools#161)
  Add gitblame
  [MAINT] Run black, isort, ruff, and other auto-linters on entire package (mne-tools#159)
  [MAINT] Replace setup.py with pyproject.toml (mne-tools#160)
  [BUG] Fixed issue w/ different rank-indices length (mne-tools#158)
  [MAINT] Refactor bivariate and multivariate methods into separate files (mne-tools#156)
  [MAINT] Fix failing unit tests & update CI packages (mne-tools#157)
  fixed grammar mistake
  switched to array indices & added inline comments
  updated default non-zero rank tolerance
  removed redundant list creation
  removed redundant ignored word
  switched to masked indices for multivariate conn
  updated time
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants