Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note in doc #266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add note in doc #266

wants to merge 1 commit into from

Conversation

ruuskas
Copy link
Contributor

@ruuskas ruuskas commented Dec 10, 2024

This is related to PR 13019 in MNE-Python and closes #262.

I also tried changing the example mne_inverse_label_connectivity.py to add an example use case. However, it appears that since the figure is rendered before the plot_connectivity_circle function exits, changes made afterwards do not become visible in the figure unless fig.show() is called, which leads to showing the figure twice. Workarounds to prevent this of course exist but might clutter the example unnecessarily. Thoughts?

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ruuskas, looks good. For this one we'll wait to merge until the upstream change is in and we've formalized what the namespace structure will be like (so that we're certain that fig.mne.colorbar is the correct way to access this)

Marking as "request changes" just as a reminder that we shouldn't merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to set colorbar ticks and label in plot_connectivity_circle
2 participants