Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin selenium and stop filtering its warning #13000

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

drammock
Copy link
Member

@drammock drammock commented Dec 2, 2024

The selenium workaround from #12928 is no longer needed, as an upstream fix has been released, and our CI is already pulling in the latest version:
https://app.circleci.com/pipelines/github/mne-tools/mne-python/25889/workflows/48bc89d6-279f-4b79-a579-b061f59c38af/jobs/69943?invite=true#step-118-9020_36

@larsoner
Copy link
Member

larsoner commented Dec 2, 2024

Pushed a tiny commit to fix the GL setup and marking for merge-when-green, thanks in advance @drammock !

@larsoner larsoner enabled auto-merge (squash) December 2, 2024 22:58
@larsoner larsoner merged commit 53792b1 into mne-tools:main Dec 3, 2024
29 of 30 checks passed
larsoner added a commit to larsoner/mne-python that referenced this pull request Dec 6, 2024
* upstream/main: (736 commits)
  ENH: Add round-trip channel name saving (mne-tools#13003)
  update governance (mne-tools#12896)
  pin selenium and stop filtering its warning (mne-tools#13000)
  DOC: fix return value doc of inst.get_montage() (mne-tools#12995)
  remove some ._filenames uses in favor of .filenames (mne-tools#12996)
  use eegbci.standardize instead of custom code (mne-tools#12997)
  Bump autofix-ci/action from dd55f44df8f7cdb7a6bf74c78677eb8acd40cd0a to ff86a557419858bb967097bfc916833f5647fa8c in the actions group (mne-tools#12999)
  MAINT: Update code credit (mne-tools#12998)
  MAINT: Unpin VTK (mne-tools#12991)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12988)
  Fix: update cnt.py to check missing annotation (mne-tools#12986)
  do not log about using set_montage AGAIN if it has never been used (mne-tools#12984)
  DOC: fix numpy docstr example Vectorizer() (mne-tools#12983)
  Changed epochs_clean_sub = model_plain.apply(epochs) to epochs_clean_sub = model_sub.apply(epochs), making use of the regression coefficients from model_sub. mne-tools#12977 (mne-tools#12978)
  DOC: add meegkit to related software suite (mne-tools#12976)
  DOC: specify tmax_raw param may be None, and what it means (mne-tools#12972)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12975)
  DOC: fix note in legacy pick_channels func (mne-tools#12973)
  Use `uint16_codec` argument (mne-tools#12971)
  Bump codecov/codecov-action from 4 to 5 in the actions group (mne-tools#12970)
  ...
@drammock drammock deleted the pin-selenium branch December 20, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants