fix(ci): root deps not installed

mnfst · Sep 11, 2024 · d656420 · d656420
1 parent faad971
commit d656420
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -7,7 +7,7 @@ on:
     branches: [master, develop]
 
 jobs:
-  build:
+  test:
     runs-on: ubuntu-latest
 
     steps:
@@ -17,14 +17,11 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: '18.x'
+      - name: Install dependencies
+        run: npm install
       - name: Install dependencies
         run: npm ci --workspaces
       - name: Build App
         run: npm run build
-
-  test:
-    runs-on: ubuntu-latest
-
-    steps:
       - name: Run tests
         run: npm run test
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -25,9 +25,10 @@ Manifest is a set of several packages and [repositories](https://github.com/orgs
 | Name           | Description                                | Stack                      | Repo                                          | Package                                                    |
 | -------------- | ------------------------------------------ | -------------------------- | --------------------------------------------- | ---------------------------------------------------------- |
 | Manifest       | Manifest core                              | NestJS / Express / TypeORM | [manifest](https://github.com/mnfst/manifest) | [manifest](https://www.npmjs.com/package/manifest)         |
-| Manifest Admin | Official Admin Panel                       | Angular                    | [manifest](https://github.com/mnfst/manifest) | [@mnfst/admin](https://www.npmjs.com/package/@mnfst/admin) |
+| Manifest Admin | Official Admin Panel                       | Angular                    | [manifest](https://github.com/mnfst/manifest) | -                                                          |
 | Add Manifest   | NPX install script                         | OCLIF                      | [manifest](https://github.com/mnfst/manifest) | [add-manifest](https://www.npmjs.com/package/add-manifest) |
 | JS SDK         | JavaScript SDK                             | TypeScript                 | [manifest](https://github.com/mnfst/manifest) | [@mnfst/sdk](https://www.npmjs.com/package/@mnfst/sdk)     |
+| Manifest Types | Utility types                              | TypeScript                 | [manifest](https://github.com/mnfst/manifest) | -                                                          |
 | Website        | Official website: https://manifest.build   | NextJS                     | [website](https://github.com/mnfst/website)   | -                                                          |
 | Docs           | Documentation: https://manifest.build/docs | Markdown / Docusaurus      | [docs](https://github.com/mnfst/docs)         | -                                                          |
 
@@ -73,9 +74,21 @@ This rule applies to all repositories.
 From the root of the repository, run:
 
 ```
+npm install
 npm install --workspaces
 
 npm run dev
 ```
 
+The you can play around with your [backend.yml](https://manifest.build/docs/manifest-file) file at `packages/core/manifest/manifest/backend.yml` and see the results:
+
+- Admin panel `http://localhost:4200`
+- API Doc `http://localhost:3000/api`
+
+### Test
+
+```
+npm run test
+```
+
 **Happy coding!** 🤗
diff --git a/packages/core/manifest/src/manifest/json-schema/definitions/entity-schema.json b/packages/core/manifest/src/manifest/json-schema/definitions/entity-schema.json
@@ -53,7 +53,7 @@
       "$ref": "./policies/policies-schema.json"
     },
     "validation": {
-      "description": "Validation object for the properties.",
+      "description": "Validation object for the properties. Doc: https://manifest.build/docs/validation",
       "type": "object",
       "properties": {
         "*": {