Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Remote YAML file #256

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

✨ Remote YAML file #256

wants to merge 5 commits into from

Conversation

brunobuddy
Copy link
Contributor

Description

This PR adds the possibility on add a path in the .env file for a remote backend.yml file.

It also refactors the Manifest module removing a lot of complexity, and adds several tests that take the coverage from 45% to 56%.

Related Issues

How can it be tested?

In your packages/core/manifest/.env.contribution file, add a MANIFEST_FILE_PATH variable that corresponds to an absolute URL where your backend.yml file is.

Don't have one ? Use this one.

Impacted packages

Check the NPM packages that require a new publication or release:

Check list before submitting

  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • I updated the "examples" dependencies is new packages have been released
  • This PR is wrote in a clear language and correctly labeled

@brunobuddy brunobuddy requested a review from SebConejo December 23, 2024 14:50
@brunobuddy brunobuddy self-assigned this Dec 23, 2024
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
manifest-schema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 2:50pm

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 76.61290% with 58 lines in your changes missing coverage. Please review.

Project coverage is 52.89%. Comparing base (0e008f7) to head (b60de8c).

Files with missing lines Patch % Lines
...t/src/manifest/services/entity-manifest.service.ts 74.59% 29 Missing and 2 partials ⚠️
...manifest/services/relationship-manifest.service.ts 80.00% 8 Missing and 1 partial ⚠️
...es/core/manifest/src/crud/services/crud.service.ts 20.00% 8 Missing ⚠️
...ore/manifest/src/manifest/services/yaml.service.ts 81.25% 3 Missing ⚠️
.../core/manifest/src/seed/services/seeder.service.ts 50.00% 2 Missing ⚠️
packages/core/manifest/src/auth/auth.service.ts 75.00% 1 Missing ⚠️
...re/manifest/src/auth/guards/authorization.guard.ts 75.00% 1 Missing ⚠️
...ifest/src/entity/services/entity-loader.service.ts 66.66% 1 Missing ⚠️
...ore/manifest/src/entity/services/entity.service.ts 66.66% 1 Missing ⚠️
...ore/manifest/src/upload/services/upload.service.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   45.54%   52.89%   +7.34%     
==========================================
  Files          40       42       +2     
  Lines        1190     1210      +20     
  Branches      289      300      +11     
==========================================
+ Hits          542      640      +98     
+ Misses        647      527     -120     
- Partials        1       43      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunobuddy brunobuddy marked this pull request as ready for review December 23, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seed command not working while setting up development environment
2 participants