Skip to content

Conversation

@zhravan
Copy link

@zhravan zhravan commented Sep 12, 2025

Description

This PR add simple workflow to validate create-manifest logic and also script that verfies whether the required files are generated or not.

Related Issues

How can it be tested?

Currently testing it with raising PR with master branch

Check list before submitting

  • This PR is wrote in a clear language and correctly labeled
  • I created the related changeset for my changes with npx changeset
  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR

@zhravan zhravan changed the title Feat/workflow manifest creation feat: github workflow that runs create-manifest on OSes Sep 12, 2025
@zhravan
Copy link
Author

zhravan commented Sep 12, 2025

@brunobuddy: Due to setting, I think can run this workflow only upon merging, could you make the action ruleset lenient so that this could be tested before merge?

@codecov
Copy link

codecov bot commented Sep 12, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@d46a778). Learn more about missing BASE report.
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #509   +/-   ##
=========================================
  Coverage          ?   92.17%           
=========================================
  Files             ?       69           
  Lines             ?     2287           
  Branches          ?      584           
=========================================
  Hits              ?     2108           
  Misses            ?      160           
  Partials          ?       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhravan
Copy link
Author

zhravan commented Sep 12, 2025

@brunobuddy : PR is ready for review, you can review the changes. TIA.

@brunobuddy
Copy link
Contributor

@zhravan the new check failed, do you know why ?

@zhravan
Copy link
Author

zhravan commented Sep 17, 2025

@brunobuddy: Can you retrigger the build? For setting up, i was doing npm ci which skipped the dev dependencies, I have updated that consider dev deps for installation, npm i, it should work now

Because it skipped dev deps, hsuky setup failed

      - name: Install dependencies (workspaces)
        run: npm i --workspaces

fyi: #509 (comment)

@zhravan
Copy link
Author

zhravan commented Oct 13, 2025

@brunobuddy : Is there anything missing from my end here?

@brunobuddy
Copy link
Contributor

@zhravan i triggered the build again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants