-
-
Notifications
You must be signed in to change notification settings - Fork 143
feat: github workflow that runs create-manifest on OSes #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@brunobuddy: Due to setting, I think can run this workflow only upon merging, could you make the action ruleset lenient so that this could be tested before merge? |
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #509 +/- ##
=========================================
Coverage ? 92.17%
=========================================
Files ? 69
Lines ? 2287
Branches ? 584
=========================================
Hits ? 2108
Misses ? 160
Partials ? 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@brunobuddy : PR is ready for review, you can review the changes. TIA. |
|
@zhravan the new check failed, do you know why ? |
|
@brunobuddy: Can you retrigger the build? For setting up, i was doing Because it skipped dev deps, hsuky setup failed fyi: #509 (comment) |
|
@brunobuddy : Is there anything missing from my end here? |
|
@zhravan i triggered the build again ! |
Description
This PR add simple workflow to validate create-manifest logic and also script that verfies whether the required files are generated or not.
Related Issues
How can it be tested?
Currently testing it with raising PR with master branch
Check list before submitting
npx changeset