Skip to content

Conversation

@gbsierra
Copy link

@gbsierra gbsierra commented Oct 8, 2025

Description

This change adds cross-platform compatibility using shx and a conditional for Swagger's custom CSS loading. Specifically tested with Windows 11 version 24H2 (OS Build 26100.6584)

How can it be tested?

Follow the 'Getting Started' steps in: https://github.com/mnfst/manifest?tab=contributing-ov-file

Check list before submitting

  • This PR is wrote in a clear language and correctly labeled
  • I created the related changeset for my changes with npx changeset
  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR

…shx and a conditional for Swagger's custom CSS loading. Specifically tested with Windows 11 version 24H2 (OS Build 26100.6584)
@codecov
Copy link

codecov bot commented Oct 13, 2025

Bundle Report

Changes will decrease total bundle size by 162.82kB (-8.76%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
manifest 1.69MB -162.82kB (-8.76%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: manifest

Assets Changed:

Asset Name Size Change Total Size Change (%)
manifest/src/main.js 366 bytes 5.75kB 6.8% ⚠️
assets/dummy-image.jpg (Deleted) -118.71kB 0 bytes -100.0% 🗑️
open-api/styles/swagger-custom.css (Deleted) -33.76kB 0 bytes -100.0% 🗑️
assets/dummy-invoice.pdf (Deleted) -10.72kB 0 bytes -100.0% 🗑️

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.12%. Comparing base (8cc14b9) to head (def8ef8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   92.17%   92.12%   -0.05%     
==========================================
  Files          69       69              
  Lines        2287     2287              
  Branches      584      582       -2     
==========================================
- Hits         2108     2107       -1     
- Misses        160      161       +1     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brunobuddy
Copy link
Contributor

Hello @gbsierra,

I am not sure what issue is this PR solving... Can you create an issue first explaining the expected behavior ? And it seams that some files have been deleted, can you tell why ?

@brunobuddy brunobuddy self-requested a review October 16, 2025 13:23
Copy link
Contributor

@brunobuddy brunobuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants