-
-
Notifications
You must be signed in to change notification settings - Fork 142
fix(build): add Windows cross-platform support with shx #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…shx and a conditional for Swagger's custom CSS loading. Specifically tested with Windows 11 version 24H2 (OS Build 26100.6584)
Bundle ReportChanges will decrease total bundle size by 162.82kB (-8.76%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: manifestAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
==========================================
- Coverage 92.17% 92.12% -0.05%
==========================================
Files 69 69
Lines 2287 2287
Branches 584 582 -2
==========================================
- Hits 2108 2107 -1
- Misses 160 161 +1
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello @gbsierra, I am not sure what issue is this PR solving... Can you create an issue first explaining the expected behavior ? And it seams that some files have been deleted, can you tell why ? |
brunobuddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
Description
This change adds cross-platform compatibility using shx and a conditional for Swagger's custom CSS loading. Specifically tested with Windows 11 version 24H2 (OS Build 26100.6584)
How can it be tested?
Follow the 'Getting Started' steps in: https://github.com/mnfst/manifest?tab=contributing-ov-file
Check list before submitting
npx changeset