Don't use inline JS where possible.

mnot · Dec 21, 2023 · 759e89d · 759e89d
1 parent 360457b
commit 759e89d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/redbot/formatter/templates/footer.html b/redbot/formatter/templates/footer.html
@@ -4,11 +4,9 @@
         <p class="navigation">
             version {{ redbot_version }} (httplint {{ httplint_version }}) |
             <a href="https://REDbot.org/about/">about</a> |
-            <script type="text/javascript" nonce="{{ nonce }}">
-                document.write('<a href="#help" id="help"><strong>help</strong></a> |')
-            </script>
+            <span class="js"><a href="#help" id="help"><strong>help</strong></a> |</span>
             <span class="help hidden">Drag the bookmarklet to your bookmark bar - it makes checking easy!</span>
-            <a href="javascript:(function(){window.open('{{ baseuri }}?uri='+encodeURIComponent(location))})();"
+            <a class="js" href="javascript:(function(){window.open('{{ baseuri }}?uri='+encodeURIComponent(location))})();"
                 title="drag me to your toolbar to use REDbot any time.">REDbot</a> bookmarklet
         </p>
 

diff --git a/redbot/formatter/templates/response_finish.html b/redbot/formatter/templates/response_finish.html
@@ -34,10 +34,8 @@
 
             <br/>
 
-            <div class='option' title='View this response content (with any gzip compression removed)'>
-                <script type="text/javascript" nonce="{{ nonce }}">
-                    document.write("<a href='#' id='body_view' accesskey='b'>view content</a>")
-                </script>
+            <div class='option js' title='View this response content (with any gzip compression removed)'>
+                <a href='#' id='body_view' accesskey='b'>view content</a>
             </div>
 
             {% if is_resource %}

diff --git a/src/js/red_script.js b/src/js/red_script.js
@@ -3,6 +3,10 @@
 import { qs, qsa, docReady, toggleHidden, config } from './red_util.js'
 
 docReady(function () {
+  qsa('.js', function (item) {
+    item.style.display = 'unset'
+  })
+
   qsa('#request_form, form.link', function (form) {
     form.onsubmit = captchaLink
   })

diff --git a/src/scss/red_layout.scss b/src/scss/red_layout.scss
@@ -70,6 +70,10 @@ h3 {
   display: none;
 }
 
+.js {
+  display: none;
+}
+
 .hilight {
   color: #d33;
 }