Interceptor added to retrofit client #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sobhan-mp
changed the title
|
Closes #25 |
data/network/src/main/java/io/filmtime/data/network/NetworkModule.kt
Outdated
Show resolved
Hide resolved
moallemi
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Thanks for your contribution @Sobhan-mp. Please review the comments and apply the changes. Do not forget to format code as mentioned in README
data/network/src/main/java/io/filmtime/data/network/TmdbMoviesService.kt
Outdated
Show resolved
Hide resolved
data/network/src/main/java/io/filmtime/data/network/TmdbMoviesService.kt
Outdated
Show resolved
Hide resolved
data/network/src/main/java/io/filmtime/data/network/TmdbShowsService.kt
Outdated
Show resolved
Hide resolved
| ): NetworkResponse<TmdbShowDetailsResponse, TmdbErrorResponse> | ||
|
|
||
| @GET("trending/tv/{time_window}") | ||
| suspend fun getTrendingShows( | ||
| @Path("time_window") timeWindow: String, | ||
| @Query("api_key") apiKey: String = BuildConfig.TMDB_API_KEY, | ||
| @Path("time_window") timeWindow: String |
There was a problem hiding this comment.
same about trailing commas
Suggested change
| @Path("time_window") timeWindow: String | |
| @Path("time_window") timeWindow: String, |
data/network/src/main/java/io/filmtime/data/network/NetworkModule.kt
Outdated
Show resolved
Hide resolved
data/network/src/main/java/io/filmtime/data/network/interceptor/ApiKeyInterceptor.kt
Outdated
Show resolved
Hide resolved
|
@hadi-norouzi @moallemi Thank you both for your comments. I have updated my branch with adding required changes. |
|
Hi @moallemi , Are there any problems? Since you haven't accepted my pr yet... |
moallemi
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.