Feature/cache detail #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moallemi
reviewed
May 4, 2024
data/database/src/main/java/io/filmtime/data/database/DatabaseModule.kt
Outdated
Show resolved
Hide resolved
data/database/src/main/java/io/filmtime/data/database/FilmTimeDatabase.kt
Outdated
Show resolved
Hide resolved
data/database/src/main/java/io/filmtime/data/database/MovieDetailEntity.kt
Outdated
Show resolved
Hide resolved
data/tmdb-movies/src/main/java/io/fimltime/data/tmdb/movies/MovieDetailEntityExt.kt
Outdated
Show resolved
Hide resolved
data/tmdb-movies/src/main/java/io/fimltime/data/tmdb/movies/TmdbMovieRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
data/tmdb-movies/src/main/java/io/fimltime/data/tmdb/movies/TmdbMovieRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
|
@hadi-norouzi let me know when your PR is ready for review |
hadi-norouzi
commented
May 8, 2024
data/tmdb-movies/src/main/java/io/fimltime/data/tmdb/movies/TmdbMovieRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
moallemi
reviewed
May 12, 2024
Comment on lines
+7
to
+16
| @TypeConverter | ||
| fun stringToList(stringList: String): List<String> { | ||
| return stringList.split(",") | ||
| } | ||
|
|
||
| @TypeConverter | ||
| fun listToString(list: List<String>): String { | ||
| return list.joinToString(",") | ||
| } | ||
| } |
There was a problem hiding this comment.
It may seem like I'm splitting hairs, but this approach has some corner cases. e.g: You try to store
listOf("A,B", "C", "D")and you restore as:
listOf("A", "B", "C", "D")No need to change it right now.
feature/movie-detail/src/main/java/io/filmtime/feature/movie/detail/MovieDetailScreen.kt
Outdated
Show resolved
Hide resolved
| is Success -> { | ||
| _state.update { state -> | ||
| state.copy(videoDetail = result.data, isLoading = false) | ||
| _state.update { it.copy(isLoading = true) } |
There was a problem hiding this comment.
there is a known bug here that we should reset error as well. otherwise our offline implementation does not work well.
Suggested change
| _state.update { it.copy(isLoading = true) } | |
| _state.update { it.copy(isLoading = true, error = null) } |
feature/movie-detail/src/main/java/io/filmtime/feature/movie/detail/MovieDetailViewModel.kt
Outdated
Show resolved
Hide resolved
It's completed. |
moallemi
approved these changes
May 15, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cache permanent movie details in the Room database.
Checklist
Fixes #56