feat: start trial option if not started #2288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
proksh
commented
Feb 4, 2025
proksh
commented
| val response = client.newCall(trialRequest).execute() | ||
| return response.isSuccessful; | ||
| } catch (e: IOException) { | ||
| println("Network error while starting trial: ${e.message}") |
There was a problem hiding this comment.
Hmmm, how are we handling IO exceptions in other places?
I recall that we're retrying in some cases. Should this failure also be retried, or would it be better to refine this message to guide the user on the appropriate action when this happens?
WDYT?
There was a problem hiding this comment.
I don't think we need to retry here. Since we are showing appropriate error message here, and start trial is one time only thing for any user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.