Mobilecoind scis #3212
Mobilecoind scis #3212
Conversation
still to come: incorporating scis into transactions i also tweaked mob tool because it seemed to hang when i pulled a new docker image, this tweak makes it display the output.
| maybe_run(pull_image_command) | ||
| else: | ||
| maybe_run_quiet(pull_image_command) | ||
| maybe_run(pull_image_command) |
There was a problem hiding this comment.
@jgreat i changed this because, i had a negative user experience when the docker image was revved. The mob prompt command seems to just hang for several minutes without any output. This way, it shows that output. Since the first time the user uses the tool, it's going to do that, I think this is a big improvement
cbeck88
requested review from
a team and
NotGyro
and removed request for
sugargoat and
a team
| .get_tx_out_index_by_hash(&utxo.tx_out.hash())?; | ||
| log::trace!(logger, "Got global index: {}", global_index); | ||
|
|
||
| // Get a ring of mixins and their proofs |
There was a problem hiding this comment.
Is there a benefit from excluding the utxo index here when we check whether the utxo is in the ring in build sci?
There was a problem hiding this comment.
I think the code where we check if the utxo is in the ring is a bit janky, IIRC the network requires you to supply a certain number of rings, so in the case that the utxo isn't present and is then added later, you will probably have the wrong ring size and have an invalid transaction.
I'm not 100% sure on that, I took the existing working code from build_transaction.
Co-authored-by: wjuan-mob <[email protected]>
Co-authored-by: Eran Rundstein <[email protected]>
This adds support for swap proposals and SCIs to mobilecoind.
This is meant to help test the deqs project, which is hard if there is not some wallet software that can incorporate SCIs or make swap proposals.