Feature/flexible memo #3269
Open
Feature/flexible memo #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjuan-mob
force-pushed
the
feature/flexible-memo
branch
from
8a23aba to
0c6e10c
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
wjuan-mob
changed the base branch from
master
to
chore/cleanup-memo-handler-for-memo-with-data
wjuan-mob
force-pushed
the
feature/flexible-memo
branch
from
ef0aa0d to
f8be8e7
Compare
This was referenced Mar 23, 2023
Merged
Base automatically changed from
chore/cleanup-memo-handler-for-memo-with-data
to
feature/add_new_memo_with_data_types
March 23, 2023 07:30
wjuan-mob
force-pushed
the
feature/add_new_memo_with_data_types
branch
from
544eafc to
962582a
Compare
wjuan-mob
force-pushed
the
feature/flexible-memo
branch
from
f8be8e7 to
63c4032
Compare
wjuan-mob
force-pushed
the
feature/add_new_memo_with_data_types
branch
from
962582a to
c5b043b
Compare
wjuan-mob
force-pushed
the
feature/flexible-memo
branch
3 times, most recently
from
db24e9e to
f78296e
Compare
wjuan-mob
force-pushed
the
feature/add_new_memo_with_data_types
branch
from
edf0043 to
5958a24
Compare
wjuan-mob
force-pushed
the
feature/flexible-memo
branch
from
f78296e to
7a67b65
Compare
wjuan-mob
requested review from
cbeck88,
nick-mobilecoin,
dolanbernard,
a team,
jcape and
samdealy
and removed request for
nick-mobilecoin and
a team
wjuan-mob
force-pushed
the
feature/flexible-memo
branch
from
9f8a756 to
bed6d74
Compare
wjuan-mob
force-pushed
the
feature/flexible-memo
branch
2 times, most recently
from
2532518 to
a91a0fe
Compare
wjuan-mob
force-pushed
the
feature/flexible-memo
branch
from
f1e6b26 to
e9905e0
Compare
samdealy
suggested changes
Apr 17, 2023
|
✅ Good job, full-service was built successfully. |
samdealy
suggested changes
Apr 18, 2023
cbeck88
reviewed
Apr 18, 2023
cbeck88
reviewed
Apr 19, 2023
samdealy
approved these changes
Apr 19, 2023
Co-authored-by: Sam Dealy <[email protected]>
Co-authored-by: Sam Dealy <[email protected]>
Co-authored-by: Sam Dealy <[email protected]>
Co-authored-by: Sam Dealy <[email protected]>
cbeck88
reviewed
Apr 19, 2023
cbeck88
reviewed
Apr 19, 2023
cbeck88
suggested changes
Apr 19, 2023
|
William has pointed out that this MCIP has paired the payment request id and payment intent id memo types: https://github.com/mobilecoinfoundation/mcips/blob/main/text/0054-rth-payment-id-memos.md So that was why we had flexible change memos. I think we should only allow 0x01 for the authenticated sender memo type bytes, and only 0x02 for the change memo types here, and so restrict the API. We should also allow defaulting either of the flexible memo payload parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flexible memo generator option to RTHbuilder
Change set payment intent and set payment request to return a result, which will error when one or the other has already been set.
Add tests for flexible memo generation
Add compute_authenticated_sender_memo and compute_destination_memo
Motivation
This is intended to address issue 3200
This should help provide a way for users to quickly add custom memo types which adhere to the authenticatedsender and destination format while taking advantage of the additional unused 32 bytes.
Future Work
Add tests to sample paykit for the flexible memo generation