Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mobilecoinofficial/gh-actions where possible #3859

Merged
merged 12 commits into from
Jan 18, 2024
Merged

use mobilecoinofficial/gh-actions where possible #3859

merged 12 commits into from
Jan 18, 2024

Conversation

jgreat
Copy link
Contributor

@jgreat jgreat commented Jan 12, 2024

Motivation

Simplify and centralize maintenance of common upstream actions. We can maintain action versions in one place instead of individually across all of our repos.

Use some simplified combined actions to replace repetitive multi step jobs (like mobilecoinofficial/gh-actions/docker)

  • Replace actions/checkout with mobilecoinofficial/gh-actions/checkout
  • Replace docker* actions with combined mobilecoinofficial/gh-actions/docker
  • Clean up unused "skip" if statements. Skipping parts of the workflow will just end up with failed later steps.

@jgreat jgreat force-pushed the use-mc-gh-actions branch from dccefa5 to 4a909d9 Compare January 12, 2024 23:00
nick-mobilecoin
nick-mobilecoin approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these get updated too?

.github/workflows/dependent-repos.yml
21:    - uses: actions/checkout@v4
41:    - uses: actions/checkout@v4

.github/workflows/android-bindings-dispatch.yml Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@jgreat jgreat merged commit 47f1f73 into release/v6.0 Jan 18, 2024
95 checks passed
@jgreat jgreat deleted the use-mc-gh-actions branch January 18, 2024 00:31
@nick-mobilecoin nick-mobilecoin mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-mobilecoin nick-mobilecoin nick-mobilecoin approved these changes

@joekottke joekottke joekottke approved these changes

@aweis89 aweis89 Awaiting requested review from aweis89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgreat @joekottke @nick-mobilecoin