Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0 CD build improvements #3949

Merged
merged 12 commits into from
Apr 2, 2024
Merged

6.0 CD build improvements #3949

merged 12 commits into from
Apr 2, 2024

Conversation

jgreat
Copy link
Contributor

@jgreat jgreat commented Mar 28, 2024 •
edited
Loading

Motivation

Clean up development build process

  • use cargo build --release --locked and just build all binaries instead of a list of -p options.
  • move to using actions from mobilecoinofficial/gh-actions for centralized maintenance of 3rd party actions.
  • Use global env vars for artifact and cache paths.
  • remove local cache actions, using standardized gh-actions instead.
  • move CACHE_BUSTER value from repo secret to variable.
  • move artifacts uploads to sub-directory so resulting zip file doesn't dump files in the current directory when blindly unzipping.
  • update print_details with dev/test network current configuration.
  • add job to print out MRSIGNER/MRENCLAVE values for the build
  • add an artifact that just has the enclave css measurement files.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@jgreat jgreat marked this pull request as ready for review April 1, 2024 22:09
@jgreat jgreat changed the title WIP: 6.0 build improvements 6.0 CD build improvements Apr 1, 2024
@jgreat jgreat merged commit 39cdbb2 into release/v6.0 Apr 2, 2024
99 checks passed
@jgreat jgreat deleted the 6_0_build_improvements branch April 2, 2024 14:54
@nick-mobilecoin nick-mobilecoin mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekottke joekottke joekottke approved these changes

@nick-mobilecoin nick-mobilecoin Awaiting requested review from nick-mobilecoin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgreat @joekottke