6.0 consensus chart refactor #3951
Conversation
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
{{ message }}
Merged
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joekottke
approved these changes
Apr 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor consensus-node chart to be more flux and helm diff friendly. Remove some of the configuration abstractions. This is a bit of a trade off in configuration complexity having the user provide secrets/configmaps instead of generating objects from a "configuration" chart.
actionlintwithshellcheckand clean up lint error and adopt better practices. This is where a lot of the quotes and missingEOFadditions come from.consensus-node-config,mc-core-common-config,mc-core-dev-env-setupcharts. These functions have been moved intomobilecoin-workflow-dev-setup-envrionment.yamlGHA workflow.consensus-nodechart to use external configmaps/secrets and remove any functionality that required alookupcall. Some values will need to be provided at deployment time.consensus-nodechart README with new required k8s objects and example values.