Update for new lints arriving in 1.72 stable #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there were extra spaces before some braces that cargo fmt 1.72 now removes. We also only suppressed the `incorrect_clone_impl_on_copy_type` clippy warning on beta. This is now suppressed for both stable and beta CI runs. This is *not* suppressed at globally or at the usage location as it would violate our 1.62.1 MSRV.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
github-actions
bot
added
the
github_actions
Codecov Report
@@ Coverage Diff @@
## main #416 +/- ##
=======================================
Coverage 88.39% 88.39%
=======================================
Files 40 40
Lines 5643 5643
=======================================
Hits 4988 4988
Misses 655 655
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nick-mobilecoin
requested review from
dolanbernard
and removed request for
a team
dolanbernard
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there were extra spaces before some braces that cargo fmt
1.72 now removes. We also only suppressed the
incorrect_clone_impl_on_copy_typeclippy warning on beta. This is nowsuppressed for both stable and beta CI runs. This is not suppressed at
globally or at the usage location as it would violate our 1.62.1 MSRV.