Derive Serialize and Deserialize for the TcbError
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage 88.39% 88.39%
=======================================
Files 40 40
Lines 5643 5643
=======================================
Hits 4988 4988
Misses 655 655 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
nick-mobilecoin
requested review from
eranrund and
dolanbernard
and removed request for
a team
Any error that is meant out be propagated out of an enclave needs to be able to be serialized and deserialized from the trusted side into the untrusted side. `Clone` was also added as the changes needed for `Serialize` and `Deserialize` made it possible for the error to be cloneable.
nick-mobilecoin
force-pushed
the
nick/cloneable-tcb-error
branch
from
b861264 to
33998eb
Compare
nick-mobilecoin
changed the title
Clone for the TcbErrorSerialize and Deserialize for the TcbError
dolanbernard
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any error that is meant out be propagated out of an enclave needs to
be able to be serialized and deserialized from the trusted side into the
untrusted side.
Clonewas also added as the changes needed forSerializeandDeserializemade it possible for the error to be cloneable.