Trim null bytes from Collateral strings #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Collateral` strings are coming from a C api which includes the null trailing byte in the length. In order to work with strict JSON parsers the null byte is omitted from the final rust `String`.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Oct 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 88.39% 88.46% +0.06%
==========================================
Files 40 40
Lines 5643 5677 +34
==========================================
+ Hits 4988 5022 +34
Misses 655 655
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nick-mobilecoin
requested review from
eranrund and
dolanbernard
and removed request for
a team
|
That clippy (beta) build is non blocking. I'm a bit torn on the beta builds, this isn't the first time it's cropped up because downstream is chaning, at the same time if we don't keep up on it then Also fixed in, #428 |
eranrund
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Collateralstrings are coming from a C api which includes the nulltrailing byte in the length. In order to work with strict JSON parsers
the null byte is omitted from the final rust
String.