Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SGX SDK to 2.20.100.4 #430

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Update SGX SDK to 2.20.100.4 #430

merged 1 commit into from
Oct 17, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Oct 13, 2023

No description provided.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Oct 13, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the size/L PRs with more than 500 lines of changes label Oct 13, 2023
@meowblecoinbot meowblecoinbot requested a review from a team October 13, 2023 21:16
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Oct 13, 2023
@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team October 13, 2023 21:44
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #430 (d7f8968) into main (90d236e) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   88.46%   88.43%   -0.03%     
==========================================
  Files          40       40              
  Lines        5677     5681       +4     
==========================================
+ Hits         5022     5024       +2     
- Misses        655      657       +2     
Files Coverage Δ
dcap/types/src/error.rs 98.63% <100.00%> (+0.01%) ⬆️
core/types/src/attributes.rs 79.65% <0.00%> (-0.70%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Oct 16, 2023

The ❌ for the build is due to some loss in coverage due to removal of the sha tests.
It's non blocking.

@nick-mobilecoin nick-mobilecoin merged commit c890555 into main Oct 17, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/sdk-2.20 branch October 17, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size/L PRs with more than 500 lines of changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants