-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable python integration tests. #1024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreat
requested review from
holtzman,
joekottke,
nick-mobilecoin,
starkriedesel and
sugargoat
as code owners
November 26, 2024 16:22
…list address by index, parsable list balance for accounts.
jgreat
force-pushed
the
jgreat/integration
branch
from
December 3, 2024 17:02
afd742a
to
186de19
Compare
holtzman
reviewed
Dec 5, 2024
holtzman
reviewed
Dec 5, 2024
holtzman
reviewed
Dec 5, 2024
holtzman
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I picked a few nits but feel free to ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Create a wrapper around the python integration tests to make funding running tests easier.
Local Testing
Integration tests can be run locally with the
tools/test-python-integration.sh
script. This script is configured with a funding full-service instance with a funding account id and a target full-service instance. The intention is to port-forward the funding instances ofdev-wallet-testnet
anddev-wallet-mainnet
instances to localhost.The test script will
Warning: Since the python tests create random accounts, the test script will scan the target full-service and attempt to send the remaining funds from any accounts still configured on the test full-service to the funding account.
Usage
FUNDING_FS_URL
defaults tohttp://localhost:9091/wallet/v2
for Testnet andhttp://localhost:9092/wallet/v2
FUNDING_ACCOUNT_ID
- see script. These accounts are configured in the dev cluster and funded with a small amount of MOB for testing.TARGET_FS_URL
defaults tohttp://localhost:9090/wallet/v2
- this is FS instance you want to testAutomated Testing
For automated tests we launch Testnet and Mainnet copies of the current container build in the
development
cluster. These instances clone their ledger volume and database from existing volumes that are kept up to date by a nightly cronjob. This saves 10+ minuets on each run over copying the ledger in from scratch or a blob storage backup.