Add MacOS signing and notary #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreat
requested review from
holtzman,
joekottke,
nick-mobilecoin,
starkriedesel and
sugargoat
as code owners
holtzman
approved these changes
Dec 5, 2024
jgreat
force-pushed
the
jgreat/macos-sign-notary
branch
from
4dffc15 to
9b0c782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add process to MacOS build to sign binaries and submit the results to the notary. This should allow the cli executables to run with just the "You have downloaded this from the web" warning instead of the "We can't verify this - go☠️" error.