-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert #784 #842
fix: revert #784 #842
Conversation
✅ Deploy Preview for mobx canceled.
|
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 56 56
Lines 1931 1933 +2
=======================================
+ Hits 1905 1907 +2
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given all discussions before
@pavanpodila news? |
Describe the changes proposed in this Pull Request.
revert #784
According to the docs, the 2.0.7+2 seems to be working correctly.
mobxjs/mobx#3144
resolve #834
resolve #836
resolve #840
Pull Request Checklist
pubspec.yaml
is updated.major
/minor
/patch
/patch-count
, depending on the complexity of changeset:versions
command usingnpm
oryarn
. You can find this command in thepackage.json
file in the root directory