Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #784 #842

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix: revert #784 #842

merged 1 commit into from
Jul 22, 2022

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Jul 6, 2022

Describe the changes proposed in this Pull Request.

revert #784

According to the docs, the 2.0.7+2 seems to be working correctly.

mobxjs/mobx#3144

resolve #834
resolve #836
resolve #840


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR
  • Run the set:versions command using npm or yarn. You can find this command in the package.json file in the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for mobx canceled.

Name Link
🔨 Latest commit a56f67f
🔍 Latest deploy log https://app.netlify.com/sites/mobx/deploys/62c4e6fd7035b90009acc721

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #842 (a56f67f) into master (c963f6c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          56       56           
  Lines        1931     1933    +2     
=======================================
+ Hits         1905     1907    +2     
  Misses         26       26           
Flag Coverage Δ
flutter_mobx 96.90% <ø> (ø)
mobx 98.32% <100.00%> (+<0.01%) ⬆️
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mobx/lib/src/api/async/async_action.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c963f6c...a56f67f. Read the comment docs.

@amondnet amondnet self-assigned this Jul 6, 2022
@amondnet amondnet requested review from pavanpodila and fzyzcjy July 6, 2022 01:37
@amondnet amondnet marked this pull request as ready for review July 6, 2022 01:37
Copy link
Collaborator

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given all discussions before

@amondnet amondnet mentioned this pull request Jul 6, 2022
7 tasks
@HudsonAfonso
Copy link

@pavanpodila news?

@amondnet amondnet merged commit 22e05da into mobxjs:master Jul 22, 2022
@amondnet amondnet deleted the revert-784 branch July 22, 2022 03:15
tlvenn pushed a commit to magelo-labs/mobx.dart_old that referenced this pull request Dec 31, 2022
tlvenn pushed a commit to magelo-labs/mobx.dart_old that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants