Can mobx include toGenerator type?

[chrisands]

Can mobx include toGenerator type from mobx-state-tree?

export function* toGenerator<R>(p: Promise<R>): Generator<Promise<R>, R, R> {
  return (yield p) as R
}

It helps to keep type after yield

const result = yield* toGenerator(api.getResult())
// result will be return type of api.getResult() instead of type `any`

[mweststrate]

See flowResult api

…

On Mon, 15 Feb 2021, 00:44 Andrey Osiyuk, ***@***.***> wrote: Can mobx include toGenerator type from mobx-state-tree? export function* toGenerator<R>(p: Promise<R>): Generator<Promise<R>, R, R> { return (yield p) as R} It helps to keep type after yield const result = yield* toGenerator(api.getResult())// result will be return type of api.getResult() instead of type `any` — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2804>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBEASXYDJ6TNCGWZ37TS7BU55ANCNFSM4XTY3MWA> .

[kubk]

@mweststrate Documentation isn't complete: https://mobx.js.org/actions.html#using-flow-instead-of-async--await-

Am I correct that fetchGithubProjectsSomehow() should be wrapped with flowResult ?

[kubk]

@mweststrate I've created a simple reproduction, flowResult loses types: https://www.typescriptlang.org/play?#code/PTAEGEHsAcE9QGSmgQwM4BcCmoBmAnSAW1AFlIAjAD1A1mizQC4AoLK6SfDW+ncFADsAxlgA2YlBTFYACoSIBLNFgA8AFQB8oALyh5xZWq2JQAb1DChosQAoAlE1AA3SIoAmoAL5sOXHu5YwpL4OLgAriIYipCCeGKQAO4ASozhYhgamrahaOkYTuqOoOqg7NiC7migAOJYglj4KBhcqkKwADSgioK4jaDJXe3aAPwQ1uKS0nIKRqrJ2oVlVBVV4yKTUjIGSiptgrCjJaBODc6NANwsLCAljBgswrGYoADmWBgAcuFEFP16Dl02h2RgAdLlIGJzrYAIz2K4sCJRGJxABUKGE0VigLMLFA+Mszx4aAAFpB0u4AEJYb6-f6gWCKcSeXAJFJpDK2d5fH5-fAOeGgW4AZTJFNAf1Agl5-R6mCwKE8kFwoAA5O1VSwvEA

[mweststrate]

Ok, I think in that case flowResult can be overloaded? PR welcome. I see that it doesn't do exactly the same as toGenerator, but I think the same utility can take care of both cases, to avoid some headaches for user whento use which?

…

On Mon, Feb 15, 2021 at 3:49 PM kubk ***@***.***> wrote: @mweststrate <https://github.com/mweststrate> I've created a simple reproduction, flowResult doesn't infer types: https://www.typescriptlang.org/play?#code/PTAEGEHsAcE9QGSmgQwM4BcCmoBmAnSAW1AFlIAjAD1A1mizQC4AoLK6SfDW+ncFADsAxlgA2YlBTFYACoSIBLNFgA8AFQB8oALyh5xZWq2JQAb1DChosQAoAlE1AA3SIoAmoAL5sOXHu5YwpL4OLgAriIYipCCeGKQAO4ASozhYhgamrahaOkYTuqOoOqg7NiC7migAOJYglj4KBhcqkKwADSgioK4jaDJXe3aAPwQ1uKS0nIKRqrJ2oVlVBVV4yKTUjIGSiptgrCjJaBODc6NANwsLCAljBgswrGYoADmWBgAcuFEFP16Dl02h2RgAdLlIGJzrYAIz2K4sCJRGJxABUKGE0VigLMLFA+Mszx4aAAFpB0u4AEJYb6-f6gWCKcSeXAJFJpDK2d5fH5-fAOeGgW4AZTJFNAf1Agl5-R6mCwKE8kFwoAA5O1VSwvEA — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2804 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBDIJMY6A3FRWI4FHZDS7E7BNANCNFSM4XTY3MWA> .