vendor: go.etcd.io/bbolt v1.3.11 #5288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/dependencies
crazy-max
force-pushed
the
update-bbolt
branch
from
6395b96
to
a58c2a5
Compare
thaJeztah
reviewed
Sep 5, 2024
Comment on lines
+189
to
+192
| _ = errors.New("") | ||
| // gofail: var lackOfDiskSpace string | ||
| // tx.rollback() | ||
| // return errors.New(lackOfDiskSpace) |
There was a problem hiding this comment.
The _ = errors.New("") confused me, but looks like it's to make sure the errors import is there, and I guess the gofail: comment is used by some tooling they use to un-comment this code in tests; etcd-io/bbolt@79bcca0
full diff: etcd-io/bbolt@v1.3.10...v1.3.11 Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
update-bbolt
branch
from
a58c2a5
to
5be2c70
Compare
tonistiigi
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: etcd-io/bbolt@v1.3.10...v1.3.11
explicit bump to go 1.22 etcd-io/bbolt#822 (review)